GNOME Bugzilla – Bug 682603
some memory leaks
Last modified: 2012-08-24 16:45:33 UTC
see attached patches
Created attachment 222304 [details] [review] file: fix leaked trash_orig_path
Created attachment 222305 [details] [review] update_restore_from_trash_action: fix leaked tooltip
Created attachment 222306 [details] [review] query: fix leaked location_uri
Created attachment 222307 [details] [review] search: fix leaked display_name
Created attachment 222308 [details] [review] eel: fix GtkTreePath leak
Created attachment 222309 [details] [review] file-utilities: fix GList leak
Created attachment 222310 [details] [review] file-operations: fix GFile leak
Created attachment 222311 [details] [review] file-operations: move: fix potential GError leaks not sure about this one
Created attachment 222312 [details] [review] search-engine: fix GList leak
Created attachment 222313 [details] [review] canvas-container: fix GArray leak
Created attachment 222314 [details] [review] nautilus_view_preview_files: fix leaked uri
Created attachment 222315 [details] [review] file-operations: fix GList leak
Created attachment 222316 [details] [review] file-utilities: fix leaked path string
Created attachment 222317 [details] [review] eel: fix leaked path string
Review of attachment 222304 [details] [review]: Looks good
Review of attachment 222305 [details] [review]: ++
Review of attachment 222306 [details] [review]: ++
Review of attachment 222307 [details] [review]: ++
Review of attachment 222308 [details] [review]: ++
Review of attachment 222309 [details] [review]: ++
Review of attachment 222310 [details] [review]: ++
Review of attachment 222312 [details] [review]: ++
Review of attachment 222313 [details] [review]: ++
Review of attachment 222314 [details] [review]: ++
Review of attachment 222315 [details] [review]: ++
Review of attachment 222316 [details] [review]: Okay
Review of attachment 222317 [details] [review]: ::: eel/eel-gnome-extensions.c @@ +56,3 @@ } result = g_strconcat (quoted, " ", args, NULL); + g_free (program_in_path); AFAICS this should be moved right after g_shell_quote(), so to fix the leak also in the case we enter the if (args == NULL || args[0] == '\0') block.
Review of attachment 222311 [details] [review]: ++
Created attachment 222350 [details] [review] eel: fix leaked path string v2 >AFAICS this should be moved right after g_shell_quote()... Oops. Fixed
Review of attachment 222350 [details] [review]: ++ Thanks for all your patches!
I don't have git account. Could you commit all this?
Attachment 222304 [details] pushed as 22ffb97 - file: fix leaked trash_orig_path Attachment 222305 [details] pushed as caf94f6 - update_restore_from_trash_action: fix leaked tooltip Attachment 222306 [details] pushed as 221d103 - query: fix leaked location_uri Attachment 222307 [details] pushed as d319bf3 - search: fix leaked display_name Attachment 222308 [details] pushed as 60217c6 - eel: fix GtkTreePath leak Attachment 222309 [details] pushed as ab35125 - file-utilities: fix GList leak Attachment 222310 [details] pushed as 21ae836 - file-operations: fix GFile leak Attachment 222311 [details] pushed as 09670c2 - file-operations: move: fix potential GError leaks Attachment 222312 [details] pushed as 9dfbbf7 - search-engine: fix GList leak Attachment 222313 [details] pushed as e84114f - canvas-container: fix GArray leak Attachment 222314 [details] pushed as 00b5c87 - nautilus_view_preview_files: fix leaked uri Attachment 222315 [details] pushed as c092d25 - file-operations: fix GList leak Attachment 222316 [details] pushed as 523073f - file-utilities: fix leaked path string
Pushed to master, thanks again!