Created attachment 222237 [details] [review]
Improve the layout of the mount operation dialog

This improves the layout of the mount operations dialog to:
 * Make primary labels bold in all cases
 * Lay out the widgets in a grid
 * Put space between the two radio groups to distinguish them

Review of attachment 222237 [details] [review]:

Generally, looks good to me; we're under UI freeze though (even if it doesn't strictly apply to GTK), so maybe we should request an UI freeze break for this.

::: gtk/gtkmountoperation.c
@@ +661,3 @@
+
+      label = gtk_label_new ("");
+      gtk_container_add (GTK_CONTAINER (remember_box), label);

Why is this needed?

Review of attachment 222237 [details] [review]:

::: gtk/gtkmountoperation.c
@@ +661,3 @@
+
+      label = gtk_label_new ("");
+      gtk_container_add (GTK_CONTAINER (remember_box), label);

For a single row of space above the "remember" options. To separate them from the rest of the options.

Created attachment 222354 [details] [review]
Improve the layout of the mount operation dialog

This improves the layout of the mount operations dialog to:
 * Make primary labels bold in all cases
 * Lay out the widgets in a grid
 * Put space between the two radio groups to distinguish them

Review of attachment 222354 [details] [review]:

Ok to commit with the fixup below. I don't think UI freeze really affects this, since we are using the shell mount op in gnome now.

::: gtk/gtkmountoperation.c
@@ +417,3 @@
+  for (l = priv->user_widgets; l != NULL; l = l->next)
+    {
+      gtk_widget_set_sensitive (GTK_WIDGET (l->data), priv->anonymous == FALSE);

Not your fault, but !priv->anonymous, please

Review of attachment 222354 [details] [review]:

Oh, please also send a quick note about the string changes to gnome-i18n

Attachment 222354 [details] pushed as e296bff - Improve the layout of the mount operation dialog