After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682507 - Improve dialogs
Improve dialogs
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afp backend
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 670162 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-22 21:34 UTC by William Jon McCann
Modified: 2012-08-23 20:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use human friendly error messages. (10.48 KB, patch)
2012-08-22 21:34 UTC, William Jon McCann
reviewed Details | Review
Use human friendly error messages. (10.81 KB, patch)
2012-08-23 18:45 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2012-08-22 21:34:38 UTC
We can improve the prompts and error messages that the user may see during
the use of AFP shares.
Comment 1 William Jon McCann 2012-08-22 21:34:40 UTC
Created attachment 222195 [details] [review]
Use human friendly error messages.
Comment 2 Carl-Anton Ingmarsson 2012-08-23 06:30:58 UTC
Review of attachment 222195 [details] [review]:

::: daemon/gvfsafpserver.c
@@ +1064,3 @@
     if (initial_user)
       /* Translators: the first %s is the username, the second the host name */
+      g_string_append_printf (str, _("Enter your password for the server “%s”."), initial_user, server_name);

Remove the initial_user parameter and update translator comment

@@ +1707,3 @@
       case AFP_RESULT_ITEM_NOT_FOUND:
         g_simple_async_result_set_error (simple, G_IO_ERROR, G_IO_ERROR_FAILED,
+                                         _("Item not found."));

Item sounds a bit generic, perhaps we should print "User ID"/"Group ID" depending on the function used ( map_data->function )
Comment 3 Felix Möller 2012-08-23 08:48:50 UTC
This affects bug #670162, which should be integrated as well.
Comment 4 William Jon McCann 2012-08-23 18:45:50 UTC
Created attachment 222252 [details] [review]
Use human friendly error messages.
Comment 5 Carl-Anton Ingmarsson 2012-08-23 19:47:31 UTC
Review of attachment 222252 [details] [review]:

Looks good. Please commit.
Comment 6 Carl-Anton Ingmarsson 2012-08-23 19:52:59 UTC
Review of attachment 222252 [details] [review]:

Except the translator comment. Please fix that and commit.

::: daemon/gvfsafpserver.c
@@ +1067,3 @@
     /* create prompt */
     if (initial_user)
       /* Translators: the first %s is the username, the second the host name */

Update the translator comment
Comment 7 William Jon McCann 2012-08-23 20:07:35 UTC
*** Bug 670162 has been marked as a duplicate of this bug. ***