After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682495 - Find remote keys uses old proxy server configuration although proxy usage is disabled
Find remote keys uses old proxy server configuration although proxy usage is ...
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2012-08-22 18:48 UTC by Andres Gomez
Modified: 2013-06-18 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch honoring the ProxyMode setting (2.76 KB, patch)
2013-06-06 16:03 UTC, Andres Gomez 		none Details | Review
Let's leave the proxy resolving to smart libsoup (3.13 KB, patch)
2013-06-06 23:04 UTC, Andres Gomez 		none Details | Review
Let's leave the proxy resolving to smart libsoup (3.56 KB, patch)
2013-06-06 23:22 UTC, Andres Gomez 		committed Details | Review

Description Andres Gomez 2012-08-22 18:48:12 UTC 
Running Ubuntu Pangoline Precise 64bits and GNOME 3 / gnome-shell

I had a HTTP proxy configured. Now, in System Settings -> Network in the Proxy section I have selected "Method -> None" to not use that configured proxy.

If I open seahorse and try to search for a new key Remote -> Find Remote Keys ...

I get an error message saying that the search failed because the name resolution for the old HTTP configured proxy failed.

Hence, seahorse is not honoring the setting which says that the old configured proxy should not be used any more.
Comment 1 Andres Gomez 2013-06-06 13:33:34 UTC 
Still happening with seahorse 3.6.2 in Ubuntu Quantal Qetzal 64bits and GNOME 3
Comment 2 Andres Gomez 2013-06-06 16:03:48 UTC 
Created attachment 246173 [details] [review]
Patch honoring the ProxyMode setting

This patch makes seahorse to honor the ProxyMode setting.

This is working for "none" and "manual" but the "automatic" mode has yet to be implemented.

In any case, a much better situation than the current.
Comment 3 Andres Gomez 2013-06-06 23:04:42 UTC 
Created attachment 246201 [details] [review]
Let's leave the proxy resolving to smart libsoup

There is no need to check manually system's HTTP proxy settings since libsoup is already able to do so through the SoupProxyResolverDefault feature.

Actually, it would be good to upgrade at some point to libsoup 2.42 and migrate from soup SoupSessionAsync to just the plain SoupSession that comes already with this feature out of the box.

But libsoup 2.42 is quite new and this is work for a future patch ...
Comment 4 Andres Gomez 2013-06-06 23:22:38 UTC 
Created attachment 246204 [details] [review]
Let's leave the proxy resolving to smart libsoup

There is no need to check manually system's HTTP proxy settings.

libsoup, since 2.33.92, is already able to do so through the SoupProxyResolverDefault feature.

Actually, it would be good to upgrade at some point to libsoup 2.42 and migrate from soup SoupSessionAsync to just the plain SoupSession that comes already with this feature out of the box.

But libsoup 2.42 is quite new and this is work for a future patch ...
Comment 5 Stef Walter 2013-06-07 05:04:09 UTC 
Nice. This looks good. Pushed to seahorse master.
Comment 6 Stef Walter 2013-06-18 13:29:22 UTC 
*** Bug 578309 has been marked as a duplicate of this bug. ***