After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682469 - Fix network device activation
Fix network device activation
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-22 13:27 UTC by Dan Winship
Modified: 2012-08-22 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: fix wired/mobile activation (2.29 KB, patch)
2012-08-22 13:27 UTC, Dan Winship 		committed Details | Review
network: don't try to activate slave connections (3.33 KB, patch)
2012-08-22 13:28 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2012-08-22 13:27:57 UTC 
The wired and mobile "on/off" buttons got broken at some point since
3.4.

Noticed while writing the second patch, which fixes it to work
correctly in the presence of bond slave connections.
Comment 1 Dan Winship 2012-08-22 13:27:58 UTC 
Created attachment 222147 [details] [review]
network: fix wired/mobile activation

You have to pass the NMDevice to nm_client_activate_connection() for a
device-specific connection. This got broken at some point in the
rewrites since 3.4.
Comment 2 Dan Winship 2012-08-22 13:28:01 UTC 
Created attachment 222148 [details] [review]
network: don't try to activate slave connections
Comment 3 Richard Hughes 2012-08-22 14:17:31 UTC 
First patch looks good to me, thanks. I think you're in a better position than me to review the second one. :) Please push to master.
Comment 4 Dan Winship 2012-08-22 14:33:24 UTC 
Attachment 222147 [details] pushed as 8df1069 - network: fix wired/mobile activation
Attachment 222148 [details] pushed as 8f1b6d6 - network: don't try to activate slave connections