After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682445 - application picker button in the dash has no tooltip
application picker button in the dash has no tooltip
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.5.x
Other Linux
: Normal trivial
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 682471 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-22 09:40 UTC by Jakub Steiner
Modified: 2012-08-22 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: Add tooltip label to show applications icon (3.22 KB, patch)
2012-08-22 10:13 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dash: Fix some issues with the label API (1.19 KB, patch)
2012-08-22 10:13 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jakub Steiner 2012-08-22 09:40:06 UTC 
The new button that toggles the application picker has no tooltip. I think it should say "More applications".

Additionally it would be nice if it said "Remove from favorites" if you are about to drop a launcher there.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-22 10:13:32 UTC 
Created attachment 222126 [details] [review]
dash: Add tooltip label to show applications icon

Make the tooltip dependent on whether we are currently dragging
on hover or not.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-08-22 10:13:38 UTC 
Created attachment 222127 [details] [review]
dash: Fix some issues with the label API

Be able to call setLabelText more than once.
Comment 3 Florian Müllner 2012-08-22 14:02:39 UTC 
*** Bug 682471 has been marked as a duplicate of this bug. ***
Comment 4 Florian Müllner 2012-08-22 18:10:21 UTC 
Review of attachment 222127 [details] [review]:

Looks good.
Comment 5 Florian Müllner 2012-08-22 18:10:37 UTC 
Review of attachment 222126 [details] [review]:

Looks good, but breaks string freeze.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-08-22 18:42:53 UTC 
(In reply to comment #5)
> Review of attachment 222126 [details] [review]:
> 
> Looks good, but breaks string freeze.

We already have a "Remove" string from the previous remove favorites button, and we probably already have it in other places. How do you feel about reusing that string for now?
Comment 7 Florian Müllner 2012-08-22 18:51:15 UTC 
Review of attachment 222126 [details] [review]:

Ha! We actually do have this string in appDisplay.js \o/
Comment 8 Cosimo Cecchi 2012-08-22 18:52:47 UTC 
(In reply to comment #5)
> Review of attachment 222126 [details] [review]:
> 
> Looks good, but breaks string freeze.

Note that we're not in string freeze yet, just string changes announcement mode.
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-08-22 18:54:25 UTC 
Review of attachment 222126 [details] [review]:

Nice!
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-08-22 18:55:47 UTC 
Attachment 222126 [details] pushed as 3fafe0d - dash: Add tooltip label to show applications icon
Attachment 222127 [details] pushed as 9835352 - dash: Fix some issues with the label API