After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682443 - PATCH: Fix cheese_camera_device_update_format_table() going into an infinite loop
PATCH: Fix cheese_camera_device_update_format_table() going into an infinite ...
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
3.5.x
Other Linux
: Normal normal
: 3.6
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-22 09:38 UTC by Hans de Goede
Modified: 2012-08-22 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PATCH: Fix cheese_camera_device_update_format_table() going into an infinite loop (1.64 KB, patch)
2012-08-22 09:38 UTC, Hans de Goede
committed Details | Review

Description Hans de Goede 2012-08-22 09:38:36 UTC
Created attachment 222119 [details] [review]
PATCH: Fix cheese_camera_device_update_format_table() going into an infinite loop

Some devices report a very small min_width / height down to reporting
0x0 as minimum resolution, which causes an infinte loop in
cheese_camera_device_update_format_table().

This patch limits the minimum resultion to 160x120, both to fix the
infinite loop issue, and to remove ridiculous resolutions such as
2x2, 5x3, 11x7, 22x15 etc. which are seen in the resolution drop down on
some devices.
Comment 1 David King 2012-08-22 20:11:22 UTC
Comment on attachment 222119 [details] [review]
PATCH: Fix cheese_camera_device_update_format_table() going into an infinite loop

Pushed to master as commit 22fb392d2393019016420e158f90b3f7bf561cde, thanks.