After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682414 - network: just have a single connection details page
network: just have a single connection details page
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-22 02:44 UTC by Matthias Clasen
Modified: 2012-09-30 03:06 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Clasen 2012-08-22 02:44:50 UTC
There's essentially three cases for the connection details page:

1) The currently active connection
2) A saved connection that is not in range
3) A saved connection that is in range

In all cases, we have a NmConnection object. In the first and the third, we also have an NmAccessPoint.

We can end up going from one case to the other without going through the list:

- User clicks 'Disconnect' (1 -> 3)
- User clicks 'Connect' (3 -> 1)
- Change location (1 -> 2, 2 -> 3)

Therefore, I don't think it is a good strategy to have different pages for these cases - we don't want a page transition to happen when clicking on 'Disconnect' or 'Connect'.

Also, the automatic updating of the 'current connection' page based on the device goes wrong: e.g. if you hit disconnect, the ssid is replaced by the generic title 'Wireless'  - but we still see the details for the saved connection for that ssid, just that it is not connected anymore.

My proposal would be to have a single 'connection details' page, and refactor the code so we have the NmConnection and NmAccessPoint objects at hand when showing it. The page will have to adapt to the 3 different cases, of course.
Comment 1 Matthias Clasen 2012-09-09 02:21:20 UTC
This is implemented in the wifi-improvements branch.