After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682386 - "make check" fails due to sys/resource.h not being available
"make check" fails due to sys/resource.h not being available
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
unspecified
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-21 19:00 UTC by Dieter Verfaillie
Modified: 2012-08-21 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
win32: fix tests/sources.c (6.86 KB, patch)
2012-08-21 19:00 UTC, Dieter Verfaillie
accepted-commit_now Details | Review

Description Dieter Verfaillie 2012-08-21 19:00:13 UTC
Created attachment 222062 [details] [review]
win32: fix tests/sources.c

Subject: [PATCH] win32: fix tests/sources.c

"make check" was failing on sys/resource.h not being available on
win32. Seeing that this test just spews some numbers on stdout
whithout really testing anything we can safely replace them with
similar enough numbers by relying on g_get_monotonic_time ().

From jhbuild on Fedora 16 (running in a VirtualBox VM), before this patch:
Add same-priority sources: 14
Remove in random order: 11
Add different-priority sources: 22
Remove in random order: 13
Add sources from threads: 482
Remove sources from threads: 207

From jhbuild on Fedora 16 (running in a VirtualBox VM), after this patch:
Add same-priority sources: 23
Remove in random order: 14
Add different-priority sources: 35
Remove in random order: 20
Add sources from threads: 731
Remove sources from threads: 420

In MSYS bash on win32, after this patch:
Add same-priority sources: 19
Remove in random order: 12
Add different-priority sources: 33
Remove in random order: 11
Add sources from threads: 83
Remove sources from threads: 30
Comment 1 Dan Winship 2012-08-21 19:05:22 UTC
Comment on attachment 222062 [details] [review]
win32: fix tests/sources.c

Sure, but trim down the commit message. No need for all this stuff:

>From jhbuild on Fedora 16 (running in a VirtualBox VM), before this patch:
>Add same-priority sources: 14
>Remove in random order: 11
>Add different-priority sources: 22
>Remove in random order: 13
>Add sources from threads: 482
>Remove sources from threads: 207
>
>From jhbuild on Fedora 16 (running in a VirtualBox VM), after this patch:
>Add same-priority sources: 23
>Remove in random order: 14
>Add different-priority sources: 35
>Remove in random order: 20
>Add sources from threads: 731
>Remove sources from threads: 420
>
>In MSYS bash on win32, after this patch:
>Add same-priority sources: 19
>Remove in random order: 12
>Add different-priority sources: 33
>Remove in random order: 11
>Add sources from threads: 83
>Remove sources from threads: 30



also, note that I just copied that code from another test, so presumably there are other tests that are being skipped on windows that could be unskipped if rewritten.
Comment 2 Dieter Verfaillie 2012-08-21 19:22:04 UTC
(In reply to comment #1)
> (From update of attachment 222062 [details] [review])
> Sure, but trim down the commit message. No need for all this stuff:

Done, also added a reference to this bug report while at it.

> also, note that I just copied that code from another test, so presumably there
> are other tests that are being skipped on windows that could be unskipped if
> rewritten.

Yeah, a lot of tests are not executed due to gtester not
yet being ported to win32. Others are skipped in the Makefiles.
One (tiny) step at a time :)

Pushed as a3655be2111ee38839fe2a1fd001923d1d4ad7be