GNOME Bugzilla – Bug 682364
network: ignore unrecognized/irrelevant devices/connections
Last modified: 2012-08-21 17:38:21 UTC
A few related fixes. First, don't warn if an unrecognized device type is seen, since there are several device types in NM that the network status menu doesn't currently support. Second, if there are "bond" connections defined, don't show the individual slave members of the bond as separately-activatable connections, since they aren't. Third, don't show the "connecting" or "connected" status if the relevant connection isn't visible in the menu, since there's nothing you could do with that connection from the menu in that case. (Alternatively, maybe it would be better to add an "Unknown connection type" menu section, and just show it there?)
Created attachment 222027 [details] [review] network: ignore unrecognized/irrelevant devices/connections Don't log a warning if an unrecognized device type is seen. Don't show slave connections in the menu. (Eg, don't show the individual wired connections making up a bond, since they can't be used individually.) Make the icon only reflect the status of connections that are visible in the menu. (ie, don't show the "connecting" icon when an unrecognized connection type is connecting, and don't show a "connected" status if the only active connections are of unrecognized types.)
oh, this isn't actually tested because I don't have a working jhbuild environment; I tested against 3.4 and then rebased the patch against master...
(In reply to comment #2) > oh, this isn't actually tested because I don't have a working jhbuild > environment; I tested against 3.4 and then rebased the patch against master... I can't test bond connections, but I can confirm the patch does not completely break network menu 3.6. Also, code looks fine to commit to me.
Attachment 222027 [details] pushed as 1c92786 - network: ignore unrecognized/irrelevant devices/connections