After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682284 - mount-op: use gint64 instead of guint64 for time_left and bytes_left
mount-op: use gint64 instead of guint64 for time_left and bytes_left
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-08-20 17:48 UTC by Cosimo Cecchi
Modified: 2012-08-21 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mount-op: use gint64 instead of guint64 for time_left and bytes_left (1.53 KB, patch)
2012-08-20 17:48 UTC, Cosimo Cecchi 		reviewed Details | Review
mount-op: adapt to guint64->gint64 API change (9.13 KB, patch)
2012-08-20 17:50 UTC, Cosimo Cecchi 		committed Details | Review
mount-op: use gint64 instead of guint64 for time_left and bytes_left (2.58 KB, patch)
2012-08-21 01:51 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-08-20 17:48:31 UTC 
See attached patch; pointed out on IRC by David Zeuthen.
Comment 1 Cosimo Cecchi 2012-08-20 17:48:33 UTC 
Created attachment 221862 [details] [review]
mount-op: use gint64 instead of guint64 for time_left and bytes_left

Since those can be -1, they need to be signed.
Comment 2 Cosimo Cecchi 2012-08-20 17:50:30 UTC 
Created attachment 221863 [details] [review]
mount-op: adapt to guint64->gint64 API change
Comment 3 Colin Walters 2012-08-20 17:57:21 UTC 
Review of attachment 221862 [details] [review]:

You need to modify the signal slot in the class in gmountoperation.h too.
Comment 4 Cosimo Cecchi 2012-08-21 01:51:54 UTC 
Created attachment 221949 [details] [review]
mount-op: use gint64 instead of guint64 for time_left and bytes_left

Oops, missed that.
Comment 5 Colin Walters 2012-08-21 02:56:11 UTC 
Review of attachment 221949 [details] [review]:

Looks ok now.
Comment 6 Colin Walters 2012-08-21 02:56:38 UTC 
Review of attachment 221863 [details] [review]:

Looks reasonable
Comment 7 Cosimo Cecchi 2012-08-21 09:18:35 UTC 
Comment on attachment 221949 [details] [review]
mount-op: use gint64 instead of guint64 for time_left and bytes_left

Attachment 221949 [details] pushed as 0d8a81b - mount-op: use gint64 instead of guint64 for time_left and bytes_left
Comment 8 Cosimo Cecchi 2012-08-21 09:19:43 UTC 
Attachment 221863 [details] pushed as 6294de0 - mount-op: adapt to guint64->gint64 API change