GNOME Bugzilla – Bug 682268
Notification on adding/removing favorites is not shown
Last modified: 2012-08-27 10:16:25 UTC
Created attachment 221847 [details] Weird Artefact Steps to reproduce: Enter Activities overview. Add or remove an application from favourites (either from its context menu or by drag and drop). Actual results: The light bulb source icon is added to the tray, but no notification comes up. The source icon stays on the tray indefinitely until I do one of the following actions: 1) right click on the source then click on "Remove" 2) right click on the source then click on "Open" 3) right click on the source then left click on the source; this action produces the attached artefact. Expected result: "[Application] has been removed from favourites." Notification is shown. After some seconds, notification and source icon go away. gnome-shell built via jhbuild on Fedora 17
Created attachment 221851 [details] [review] overview: Fix ShellInfo.setMessage() Commit 22eea750 made info messages show up in the lock screen, but as setShowWhenLocked() throws an exception when called on non-transient notifications, the transient hint has to be set first.
(In reply to comment #1) Yes, this fixed the issue for me. The whole animation of message tray sliding down and notification banner siding up (and then the reverse) is a little annoying, but I guess that's a separate issue. Also, the notification is already "expanded", i.e., the "Undo" button is already visible without before moving the pointer over the banner (however, the close button is not). Is this intended?
Review of attachment 221851 [details] [review]: Looks good.
Attachment 221851 [details] pushed as 417941a - overview: Fix ShellInfo.setMessage()