After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682244 - Legacy tray icon menus no longer work (gnote, dropbox, skype)
Legacy tray icon menus no longer work (gnote, dropbox, skype)
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: message-tray
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 682250 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-20 11:24 UTC by Frederic Peters
Modified: 2015-03-07 05:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
MessageTray: escape the tray when a legacy icon is clicked (2.21 KB, patch)
2012-08-31 16:45 UTC, Giovanni Campagna
committed Details | Review

Description Frederic Peters 2012-08-20 11:24:32 UTC
Now that the new message tray has landed I got it running on my main laptop and I noticed the gnote icon no longer works; I can click on it but no menu ever happens (using a keyboard shortcut brings the gnote menu correctly).

Is this some bug, particular to gnote, or has support for "legacy" tray icons been removed?
Comment 1 Milan Bouchet-Valat 2012-08-20 12:23:11 UTC
*** Bug 682250 has been marked as a duplicate of this bug. ***
Comment 2 Giovanni Campagna 2012-08-20 12:50:34 UTC
Right-clicking of the icon itself (or left-clicking, fwiw) won't work directly, because the message tray has a grab now.
Left-clicking still works because the event is synthesized, probably right-click was lost somewhere.
Comment 3 Frederic Peters 2012-08-20 14:03:33 UTC
But left clicking, when the action is to popup a menu (like in gnote) doesn't work (because the menu also wants a grab).
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-08-20 18:06:38 UTC
Correct. Now that the message tray is modal, it's impossible for anything else to take the grab.

There's no way to fix this other than to remove gnome-shell from taking a grab and focusing a special dummy window instead, like we've discussed in the past.
Comment 5 Matthias Clasen 2012-08-27 02:37:12 UTC
As a least-effort workaround, could we drop the grab and close the messagetray on any click on a legacy icon ? That should allow the menu to be displayed (albeit with the icon already beyond the horizon again) ?
Comment 6 Giovanni Campagna 2012-08-31 16:45:31 UTC
Created attachment 223088 [details] [review]
MessageTray: escape the tray when a legacy icon is clicked

Legacy tray icons may want to take a pointer grab to show a popup menu,
and this is incompatible with message tray modality. To solve this,
escape the tray when forwarding clicks to the tray icons, and wait
for the input mode change to actually synthetize the X event.
Comment 7 drago01 2012-08-31 21:22:09 UTC
Review of attachment 223088 [details] [review]:

Definitely better then non working menus. Seems to work fine with Skype and code looks good to me.
Comment 8 Juanjo Marín 2012-09-01 14:06:34 UTC
The right click menus from the icons in the system tray only work in the overview mode, but they are shown in the desktop mode.

http://farm9.staticflickr.com/8445/7906327460_659e1f5e65_o.png
Comment 9 Giovanni Campagna 2012-09-01 14:51:24 UTC
Comment on attachment 223088 [details] [review]
MessageTray: escape the tray when a legacy icon is clicked

Attachment 223088 [details] pushed as eb351b1 - MessageTray: escape the tray when a legacy icon is clicked
Let's keep this open until we find a better solution
Comment 10 Florian Müllner 2015-03-07 05:53:38 UTC
In 3.16, legacy tray icons got a dedicated tray that doesn't use a grab, so menus work as expected now.