After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682128 - Extension styling is broken
Extension styling is broken
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-17 23:14 UTC by Giovanni Campagna
Modified: 2012-09-13 20:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix extension styling (1.26 KB, patch)
2012-09-13 20:27 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-08-17 23:14:53 UTC 
I'm not sure why, but 75e49610cbed17ae312ddd896f07503842390d27 broke stylesheets from extensions.
Reverting it works fine.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-08-18 00:47:37 UTC 
Hm. Maybe I got the inequality wrong? Try reversing it.
Comment 2 Giovanni Campagna 2012-08-18 00:58:26 UTC 
Nope, no change.

Btw, I just found out that the problem exists only if you live enable the extension after the shell is started, otherwise it works fine with your patch.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-18 01:02:38 UTC 
Hm. I guess that's why it worked for me in testing.
Comment 4 Giovanni Campagna 2012-09-13 20:27:40 UTC 
Created attachment 224274 [details] [review]
Fix extension styling

St.Theme.load_stylesheet() does not queue a theme context change, so
any styling of widgets created before will not be updated. To fix this,
load the stylesheet before the extension builds its own UI in enable()
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-09-13 20:38:17 UTC 
Review of attachment 224274 [details] [review]:

Makes sense.
Comment 6 Giovanni Campagna 2012-09-13 20:44:51 UTC 
Attachment 224274 [details] pushed as 77c15b7 - Fix extension styling