After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682124 - scanner: methods cannot have an out-arg as their first arg
scanner: methods cannot have an out-arg as their first arg
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 682125
 
 
Reported: 2012-08-17 22:28 UTC by Torsten Schoenfeld
Modified: 2015-02-07 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scanner: methods cannot have an out-arg as their first arg (5.06 KB, patch)
2012-08-17 22:28 UTC, Torsten Schoenfeld 		committed Details | Review

Description Torsten Schoenfeld 2012-08-17 22:28:53 UTC 
This patch makes it possible to get a proper representation of gdk_rgba_parse.
Comment 1 Torsten Schoenfeld 2012-08-17 22:28:55 UTC 
Created attachment 221677 [details] [review]
scanner: methods cannot have an out-arg as their first arg

This ensures that if the first argument of a function like

  gboolean gdk_rgba_parse (GdkRGBA *rgba, const gchar *spec);

is annotated as being an out-arg, the result is a class function with two
arguments, not a method with one argument.  Previously, the (out) annotation
was simply ignored.
Comment 2 Colin Walters 2012-08-20 19:21:48 UTC 
Review of attachment 221677 [details] [review]:

Makes sense, thanks!

::: giscanner/maintransformer.py
@@ +1006,3 @@
+                message.warn_node(func,
+                    '%s: The first argument of methods cannot be an '
+                    'out-argument' % func.symbol)

Very minor: the print format here is inconsistent with the rest of the code; should be (func.symbol, )
Comment 3 Torsten Schoenfeld 2012-08-21 18:53:49 UTC 
Committed with the style fixed.  Thanks for the review.

Attachment 221677 [details] pushed as b0b4c98 - scanner: methods cannot have an out-arg as their first arg
Comment 4 André Klapper 2015-02-07 17:03:51 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]