After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682093 - [PATCH] native file chooser for OS X users.
[PATCH] native file chooser for OS X users.
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Mac OS
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-17 12:12 UTC by Timo Dörr
Modified: 2012-08-21 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
native file chooser for OS X users (28.52 KB, patch)
2012-08-17 12:12 UTC, Timo Dörr 		committed Details | Review

Description Timo Dörr 2012-08-17 12:12:34 UTC 
Created attachment 221592 [details] [review]
native file chooser for OS X users

This patch enables a native file chooser on OS X. this is not only a cosmetic change, since the default Gtk Filechooser is VERY limited on OS X. With Gtk chooser, External devices (USB drives, Network shares) aren't listed, neiher are custom searches or shortcuts that are usually in the sidebar in Finder.

See my post on the mailing list: https://mail.gnome.org/archives/banshee-list/2012-July/msg00031.html

The native chooser will only be select for File/Folder media import. Other file open dialogs that require custom Gtk widgets (like the "select new album art" dialog) remain sGtk based on OS X.
Comment 1 Bertrand Lorentz 2012-08-21 19:56:57 UTC 
Comment on attachment 221592 [details] [review]
native file chooser for OS X users

Thanks for the patch!

I've committed it with a few changes to the OsxFileChooserDialog constructors. It felt like you had some leftovers from prevous attempts, with for example the title parameter not being used in OsxFileChooserDialog (string title, NSOpenPanel panel).

I'm pretty sure I didn't break anything, but you probably want to check anyway...