After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682027 - Add a symbolc icon to the empty alarm page
Add a symbolc icon to the empty alarm page
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-16 17:11 UTC by Paolo Borelli
Modified: 2012-08-16 21:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
alarm clock symbolic icon (6.46 KB, image/svg+xml)
2012-08-16 17:12 UTC, Paolo Borelli
  Details
Add empty alarm page (12.96 KB, patch)
2012-08-16 20:11 UTC, Maël Lavault
none Details | Review
Screenshot of new empty alarms view (15.67 KB, image/png)
2012-08-16 20:14 UTC, Maël Lavault
  Details
Add empty alarm page (10.62 KB, patch)
2012-08-16 20:49 UTC, Maël Lavault
none Details | Review
Add empty alarm page (10.66 KB, patch)
2012-08-16 20:52 UTC, Maël Lavault
none Details | Review

Description Paolo Borelli 2012-08-16 17:11:37 UTC
The alarm page should have an icon in the middle of the empty page, just like the world clocks.

I am attaching my attempt at an icon... it is not *that* bad so we can commit it to the gnome-clocks sources and start to work on this and in the mean time try to convince some real designer to improve the icon and maybe even add it to the icon-theme module if it makes sense.
Comment 1 Paolo Borelli 2012-08-16 17:12:21 UTC
Created attachment 221426 [details]
alarm clock symbolic icon
Comment 2 Maël Lavault 2012-08-16 20:11:10 UTC
Created attachment 221463 [details] [review]
Add empty alarm page

Here it is. I'm not very satisfied with the new_from_file approach, but it works for now.
Comment 3 Maël Lavault 2012-08-16 20:14:41 UTC
Created attachment 221464 [details]
Screenshot of new empty alarms view
Comment 4 Maël Lavault 2012-08-16 20:49:15 UTC
Created attachment 221470 [details] [review]
Add empty alarm page

Modified to install icon system wide.
Comment 5 Maël Lavault 2012-08-16 20:52:03 UTC
Created attachment 221471 [details] [review]
Add empty alarm page

Moved the icon in actions directory
Comment 6 Paolo Borelli 2012-08-16 21:45:00 UTC
Jimmac redid the icon and committed it to gnome-icon-theme-symbolic

I fixed up the patch and pushed it, thanks!