Created attachment 221361 [details] [review]
patch

Port to new documentation infrastructure

Review of attachment 221361 [details] [review]:

looks good to me, and I assume you've tested it. :-)

Actually I don't (sorry about that), but could do it tonight or tomorrow, need to setup a dev environment fist. Will test my patches before I send them next time.

Review of attachment 221361 [details] [review]:

Hey Oliver! thanks for the patch

Im not the maintainer of this module, but a little comment:

::: help/Makefile.am
@@ +4,3 @@
+
+HELP_FILES =\
+	   gnome-dictionary.xml

gnome-dictionary.xml is a docbook file, so should be renamed to index.docbook

Created attachment 221618 [details] [review]
patchV2

Thanks for the review Javier, it's fixed now.

Review of attachment 221618 [details] [review]:

Looks good, only a little comment

::: help/Makefile.am
@@ +15,3 @@
+	figures/gnome-dictionary-lookup.png
+	figures/gnome-dictionary-preferences-print.png	
+	figures/gnome-dictionary-preferences-source.png	

I think you forgot to add the "\" to the end of each line here

Review of attachment 221618 [details] [review]:

In help/Makefile.am you need to use \ at the end of each line (except for the last line) of HELP_FILES and HELP_MEDIA. Otherwise, only the first file will be installed and the other files won't be.

You need to actually rename gnome-dictionary.xml to index.docbook

You missed two ghelp: references. For instance, change ghelp:gnome-dictionary#gnome-dictionary-preferences to help:gnome-dictionary/gnome-dictionary-preferences

I think you can also rm help/gnome-dictionary.omf.in as I believe scrollkeeper isn't really used any more.

Created attachment 221797 [details] [review]
patchV3

Review of attachment 221797 [details] [review]:

We are getting there, only a minor comment

::: help/Makefile.am
@@ +9,3 @@
+HELP_MEDIA = \
+	figures/gnome-dictionary-add-source.png\	
+	figures/gnome-dictionary-applet-window.pn\g	

typo here, also separe \ from the name file

Created attachment 221817 [details] [review]
patchV4

Review of attachment 221817 [details] [review]:

if this has been tested, it's fine for me to go in.

Comment on attachment 221817 [details] [review]
patchV4

I finally commit this with some changes:
- rename help/C/gnome-dictionary.xml to help/C/index.docbook
- use / instead # in the ghelp: uris

commit 4f27e243eb1ac92c5ad93220031d508ba18ca0b9

Thanks Olivier for the patch!