After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681985 - should go out of selection mode when there are no boxes to select
should go out of selection mode when there are no boxes to select
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.5.x (unsupported)
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-16 11:09 UTC by Christophe Fergeau
Modified: 2016-03-31 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ui: Go out of selection mode after removing all boxes (1.11 KB, patch)
2012-09-05 09:45 UTC, Christophe Fergeau
committed Details | Review

Description Christophe Fergeau 2012-08-16 11:09:33 UTC
If the user deletes all boxes, we should get out of selection mode (mccann mentioned this at GUADEC).
Comment 1 Marc-Andre Lureau 2012-09-04 21:32:49 UTC
(but only when the "undelete?" popup is gone I guess)
Comment 2 Christophe Fergeau 2012-09-05 09:45:46 UTC
Created attachment 223511 [details] [review]
ui: Go out of selection mode after removing all boxes

If you delete all your boxes, we currently stay in selection mode,
and the user has to click on 'Cancel' to go out of it. After this
commit, we go out of selection mode when the collection view gets
empty after some changes in selection mode.
Comment 3 Christophe Fergeau 2012-09-05 09:47:56 UTC
(In reply to comment #1)
> (but only when the "undelete?" popup is gone I guess)

Hmm, maybe, dunno... The patch I just attached does not do that. There is work to do to refine when these popups should appear/disappear anyway...
Comment 4 Marc-Andre Lureau 2012-09-05 09:50:41 UTC
Review of attachment 223511 [details] [review]:

ack
Comment 5 Christophe Fergeau 2012-09-05 13:32:53 UTC
Attachment 223511 [details] pushed as 53124fb - ui: Go out of selection mode after removing all boxes