After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681973 - libgdm: Fix memory leaks
libgdm: Fix memory leaks
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-16 08:33 UTC by Stef Walter
Modified: 2012-08-16 19:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libgdm: Fix memory leaks (5.51 KB, patch)
2012-08-16 08:33 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-08-16 08:33:10 UTC 
 * The xxx_new_proxy_finish() functions return a result with
   a reference. Account for this.
Comment 1 Stef Walter 2012-08-16 08:33:12 UTC 
Created attachment 221350 [details] [review]
libgdm: Fix memory leaks
Comment 2 Ray Strode [halfline] 2012-08-16 17:29:55 UTC 
Review of attachment 221350 [details] [review]:

::: gui/libgdm/gdm-client.c
@@ +150,2 @@
+        user_verifier = gdm_user_verifier_proxy_new_finish (result, &error);
+        if (!user_verifier) {

we always use == NULL for pointers in GDM
Comment 3 Stef Walter 2012-08-16 19:40:32 UTC 
Attachment 221350 [details] pushed as b453043 - libgdm: Fix memory leaks