After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681971 - [0.10] videodecoder: fix invalid timestamp handling
[0.10] videodecoder: fix invalid timestamp handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-16 08:20 UTC by sreerenj
Modified: 2012-08-16 10:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the invalid timestamp assigning. (1.05 KB, patch)
2012-08-16 08:20 UTC, sreerenj 		committed Details | Review

Description sreerenj 2012-08-16 08:20:27 UTC 
Created attachment 221348 [details] [review]
Fix the invalid timestamp assigning.

This is an issue with gst-plugins-base, git version of 0.10 .

Fix frame->pts calculation if buffers come with DTS and were reordered.
If the videodecoders(subclassed from VideoDecoder) perform gst_adapter_flush() instead of gst_video_decoder_add_to_frame() (it might not be the correct way to do :)..), the input buffer timestamp in VideoDecoder might be invalid .Which will leads to invalid timestamp value in reorderd_pts. An extra checking with GST_CLOCK_TIME_IS_VALID is enough to fix this issue.
Comment 1 Sebastian Dröge (slomo) 2012-08-16 10:21:20 UTC 
commit 9105eb7cfd7707cbbbacb8c8cfdeac0d94044d9b
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Thu Aug 16 11:00:18 2012 +0300

    videodecoder: correcting PTS calculation of frame.
    
    --assign the reorderd_pts to frame->pts iff it is a VALID timestamp.