After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681950 - Fix license info
Fix license info
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-15 21:44 UTC by Alex Anthony
Modified: 2012-08-25 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Does all 3 changes (22.00 KB, patch)
2012-08-15 21:44 UTC, Alex Anthony 		needs-work Details | Review
Updated for file changes (23.32 KB, patch)
2012-08-16 13:09 UTC, Alex Anthony 		none Details | Review

Description Alex Anthony 2012-08-15 21:44:07 UTC 
Created attachment 221321 [details] [review]
Does all 3 changes

Needs a copying file adding ("You should have received a copy of the GNU General Public License along with Gnome Clocks").

One file was missing a license block altogether.

Each license block had a reference to Gnome Documents rather than Clocks.
Comment 1 Paolo Borelli 2012-08-16 12:45:52 UTC 
Review of attachment 221321 [details] [review]:

The patch looks ok to me, but it will need to be updated since we just moved the files once again :)


Seif: since we are touching this, any specific reason to use multiline strings (""") for the license instead of plain comments? I know it really does not matter in practice but strings are kept in memory at runtime while comments are discarded :)
Comment 2 Alex Anthony 2012-08-16 13:09:27 UTC 
Created attachment 221365 [details] [review]
Updated for file changes

Updated for latest changes to files
Comment 3 Paolo Borelli 2012-08-16 17:43:12 UTC 
I amended the patch to use plain comments and pushed. Thanks!