After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681943 - fix a leak and other minor issues
fix a leak and other minor issues
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-15 19:57 UTC by William Jon McCann
Modified: 2012-08-16 02:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix a string leak (1.03 KB, patch)
2012-08-15 19:57 UTC, William Jon McCann 		committed Details | Review
Bail out as soon as you find a module that matches mime type (926 bytes, patch)
2012-08-15 19:58 UTC, William Jon McCann 		committed Details | Review
Print a warning when failing to match mime type (811 bytes, patch)
2012-08-15 19:58 UTC, William Jon McCann 		rejected Details | Review

Description William Jon McCann 2012-08-15 19:57:13 UTC 
Patches here fix a string leak and other minor issues
Comment 1 William Jon McCann 2012-08-15 19:57:58 UTC 
Created attachment 221308 [details] [review]
Fix a string leak
Comment 2 William Jon McCann 2012-08-15 19:58:01 UTC 
Created attachment 221309 [details] [review]
Bail out as soon as you find a module that matches mime type
Comment 3 William Jon McCann 2012-08-15 19:58:03 UTC 
Created attachment 221310 [details] [review]
Print a warning when failing to match mime type
Comment 4 Matthias Clasen 2012-08-16 02:17:40 UTC 
Review of attachment 221308 [details] [review]:

Looks correct. The commit message should probably also mention that you avoid a 
pointless second guess call when filename is NULL.
Comment 5 Matthias Clasen 2012-08-16 02:20:17 UTC 
Review of attachment 221309 [details] [review]:

ok
Comment 6 Matthias Clasen 2012-08-16 02:22:37 UTC 
Review of attachment 221310 [details] [review]:

That seems redundant - we're already reporting this fact as a GError.
Comment 7 William Jon McCann 2012-08-16 02:29:43 UTC 
Attachment 221308 [details] pushed as db341ce - Fix a string leak
Attachment 221309 [details] pushed as 258ba2d - Bail out as soon as you find a module that matches mime type