After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681924 - vm-creator: Don't put 'Live' in domain's title
vm-creator: Don't put 'Live' in domain's title
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-08-15 16:10 UTC by Zeeshan Ali
Modified: 2016-03-31 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vm-creator: Don't put 'Live' in domain's title (6.32 KB, patch)
2012-08-15 16:10 UTC, Zeeshan Ali
reviewed Details | Review
libgd: Update GdMainColumns enum (1.69 KB, patch)
2012-08-15 20:29 UTC, Zeeshan Ali
committed Details | Review
vm-creator: Don't put 'Live' in domain's title (6.74 KB, patch)
2012-08-15 20:29 UTC, Zeeshan Ali
committed Details | Review

Description Zeeshan Ali 2012-08-15 16:10:33 UTC
SSIA
Comment 1 Zeeshan Ali 2012-08-15 16:10:36 UTC
Created attachment 221277 [details] [review]
vm-creator: Don't put 'Live' in domain's title

Now that we have a special CellRenderer in icon view that can display an
optional 2nd line of text under the boxes, we use that to display
supplementary information about the box. For now, we only show 'Live' or
'Installing..' when appropriate.
Comment 2 Marc-Andre Lureau 2012-08-15 16:53:46 UTC
Review of attachment 221277 [details] [review]:

looks good, especially when libgd will have more generic columns names

::: src/collection-view.vala
@@ +201,3 @@
+            model.set (iter, ModelColumns.INFO, machine.info);
+        });
+        item.set_data<ulong> ("info_id", info_id);

You do save info_id with set_data(), but you should realize why it's needed and fix that like the rest of the code you based on is doing.
Comment 3 Christophe Fergeau 2012-08-15 17:03:07 UTC
(In reply to comment #0)
> SSIA

The subject is far from saying it all, the patch commit log does ;)
Comment 4 Zeeshan Ali 2012-08-15 20:29:36 UTC
Created attachment 221314 [details] [review]
libgd: Update GdMainColumns enum
Comment 5 Zeeshan Ali 2012-08-15 20:29:41 UTC
Created attachment 221315 [details] [review]
vm-creator: Don't put 'Live' in domain's title

Now that we have a special CellRenderer in icon view that can display an
optional 2nd line of text under the boxes, we use that to display
supplementary information about the box. For now, we only show 'Live' or
'Installing..' when appropriate.
Comment 6 Zeeshan Ali 2012-08-15 20:31:14 UTC
(In reply to comment #3)
> (In reply to comment #0)
> > SSIA
> 
> The subject is far from saying it all, the patch commit log does ;)

Hey, I'm new at this 'SSIA' thing. :)
Comment 7 Marc-Andre Lureau 2012-08-15 21:08:55 UTC
Review of attachment 221314 [details] [review]:

if it's upstream ack
Comment 8 Marc-Andre Lureau 2012-08-15 21:09:11 UTC
Review of attachment 221315 [details] [review]:

ack
Comment 9 Zeeshan Ali 2012-08-15 21:24:19 UTC
Attachment 221314 [details] pushed as 6c62b19 - libgd: Update GdMainColumns enum
Attachment 221315 [details] pushed as c43b51e - vm-creator: Don't put 'Live' in domain's title