Created attachment 221251 [details] [review]
libgd: Import GdMainIconView

Also import the required classes (GdMainViewGeneric,
GdTogglePixbufRenderer and GdTwoLinesRenderer) and theme icons it requires
for selection mode.

Created attachment 221252 [details] [review]
collection-view: Use GdMainIconView instead of GtkIconView

While rest of the UI looks exactly it did before this change, the
selection view now looks a lot prettier (i-e like in gnome-documents).
Apart from the aesthetic benefits, we now also retain the selection when
switching away from selection view.

Most of this code is taken (and ported to Vala) from GdMainView that we
(at least currently) can not use.

Created attachment 221253 [details] [review]
Add Cosimo Cecchi to AUTHORS

We have imported enough of his code from gnome-documents to be obligated
to credit him.

Review of attachment 221253 [details] [review]:

ack

Review of attachment 221252 [details] [review]:

patch looks good, minor comments

::: src/collection-view.vala
@@ +4,2 @@
 private class Boxes.CollectionView: Boxes.UI {
+    private const int ITEM_COLUMN = Gd.MainColumns.SELECTED + 1;

It would be more future-proof to have Gd.MainColumns.LAST instead. I guess this change is acceptable too for upstream.

Also, if there is no vala limitation, it would make more sense to keep it as an enum such as ModelColumn.ITEM.

Review of attachment 221251 [details] [review]:

ack

Created attachment 221265 [details] [review]
collection-view: Use GdMainIconView instead of GtkIconView

V2: Enum changes as pointed out in last review.

Created attachment 221266 [details] [review]
collection-view: Use GdMainIconView instead of GtkIconView

V3

Review of attachment 221266 [details] [review]:

ack

Attachment 221251 [details] pushed as e77e15a - libgd: Import GdMainIconView
Attachment 221253 [details] pushed as d29519d - Add Cosimo Cecchi to AUTHORS
Attachment 221266 [details] pushed as 0e8af0a - collection-view: Use GdMainIconView instead of GtkIconView

Created attachment 221355 [details]
screenshot in selection mode

(In reply to comment #2)
> Created an attachment (id=221252) [details] [review]
> collection-view: Use GdMainIconView instead of GtkIconView

For what it's worth, the checkboxes in selection mode don't look that nice with our dark theme. On https://github.com/gnome-design-team/gnome-mockups/raw/master/boxes/boxes-selection.png they are positioned more to the left/top than what is done in git master