After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681880 - only allow manual layout in Desktop view
only allow manual layout in Desktop view
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 681917 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-14 21:27 UTC by William Jon McCann
Modified: 2012-08-16 02:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only support manual layout in Desktop views (3.45 KB, patch)
2012-08-15 22:50 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-08-14 21:27:15 UTC 
I think we should only allow manual layouts in the Desktop view. This will better prepare us for transition to icon view.
Comment 1 William Jon McCann 2012-08-15 14:15:30 UTC 
*** Bug 681917 has been marked as a duplicate of this bug. ***
Comment 2 William Jon McCann 2012-08-15 22:50:35 UTC 
Created attachment 221328 [details] [review]
Only support manual layout in Desktop views
Comment 3 Cosimo Cecchi 2012-08-16 01:43:37 UTC 
Review of attachment 221328 [details] [review]:

::: src/nautilus-canvas-view.c
@@ +627,3 @@
 	gtk_action_set_sensitive (action, !is_auto_layout);	
+	gtk_action_set_visible (action,
+				nautilus_canvas_view_supports_manual_layout (view));

AFAICS nautilus_canvas_view_supports_manual_layout() also needs to be modified to return the value of new boolean flag instead of TRUE
Comment 4 William Jon McCann 2012-08-16 01:47:14 UTC 
Review of attachment 221328 [details] [review]:

::: src/nautilus-canvas-view.c
@@ +627,3 @@
 	gtk_action_set_sensitive (action, !is_auto_layout);	
+	gtk_action_set_visible (action,
+				nautilus_canvas_view_supports_manual_layout (view));

I did, didn't I?
Comment 5 Cosimo Cecchi 2012-08-16 01:51:04 UTC 
Review of attachment 221328 [details] [review]:

Oops yeah, for some reason I didn't see it the first time.