After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681821 - Modal dialog entry labels are misaligned
Modal dialog entry labels are misaligned
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-14 09:31 UTC by Cosimo Cecchi
Modified: 2012-08-14 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (87.29 KB, image/jpeg)
2012-08-14 09:32 UTC, Cosimo Cecchi
  Details
keyringPrompt: Improve styling here as well (2.56 KB, patch)
2012-08-14 16:14 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Cosimo Cecchi 2012-08-14 09:31:15 UTC
Noticed with 3.5.5, see attached screenshot
Comment 1 Cosimo Cecchi 2012-08-14 09:32:04 UTC
Created attachment 221106 [details]
screenshot

The label on the left side of the entry is not centered, and misses some right padding.
Comment 2 Allan Day 2012-08-14 10:04:09 UTC
It would be better if the label was on top of the field, with the field expanding to fill the width of the main "column". This is what we're doing for the login screen:

http://git.gnome.org/browse/gnome-shell/commit/?id=855f0dbcadfe390857670fca49dda6109a72f134
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-08-14 15:38:08 UTC
I had a patch to fix this. I forgot to push it.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-08-14 15:39:57 UTC
Actually, no, I didn't forget to push it.

http://git.gnome.org/browse/gnome-shell/commit/?id=4d7d66bc1ff4915e33855c67574839b6efb0e06f

Why doesn't it work for you?
Comment 5 Cosimo Cecchi 2012-08-14 15:45:10 UTC
(In reply to comment #4)
> Actually, no, I didn't forget to push it.
> 
> http://git.gnome.org/browse/gnome-shell/commit/?id=4d7d66bc1ff4915e33855c67574839b6efb0e06f
> 
> Why doesn't it work for you?

Note that the dialog in the screenshot comes from the keyring agent, not from polkit. Maybe the keyring dialog is using a different style class?
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-08-14 16:14:13 UTC
Created attachment 221169 [details] [review]
keyringPrompt: Improve styling here as well

Again, center the "Password" label, and add some spacing between
it and the entry.
Comment 7 Cosimo Cecchi 2012-08-14 16:23:23 UTC
Review of attachment 221169 [details] [review]:

While it might not be the optimal solution as suggested by Allan, this fixes the issue I was seeing, so I think it's worth having it in the meantime.
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-08-14 17:31:17 UTC
Attachment 221169 [details] pushed as 9f07a3d - keyringPrompt: Improve styling here as well