After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681808 - Use double quotes instead ascii quotes
Use double quotes instead ascii quotes
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-14 04:13 UTC by William Jon McCann
Modified: 2012-08-14 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use double quotes instead of ascii quotes (41.28 KB, patch)
2012-08-14 04:34 UTC, William Jon McCann
reviewed Details | Review
Use double quotes instead of ascii quotes (39.36 KB, patch)
2012-08-14 14:47 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2012-08-14 04:13:11 UTC
We use a lot of ascii quotes when we should probably be using:
U+201C LEFT DOUBLE QUOTATION MARK
\342\200\234 

and 

U+201D RIGHT DOUBLE QUOTATION MARK
\342\200\235
Comment 1 William Jon McCann 2012-08-14 04:34:05 UTC
Created attachment 221095 [details] [review]
Use double quotes instead of ascii quotes
Comment 2 Cosimo Cecchi 2012-08-14 09:26:11 UTC
Review of attachment 221095 [details] [review]:

Not the biggest fan of this...it makes the strings impossible to read and translators' life way harder.
Maybe we could just use the actual character instead of its UTF-8 bytewise code?
Comment 3 William Jon McCann 2012-08-14 14:20:47 UTC
Yeah, it would seem that using “%s” instead of \342\200\234%s\342\200\235 is much easier to translate too. I've asked in #i18n.
Comment 4 William Jon McCann 2012-08-14 14:40:33 UTC
<friedel> those octal codes are downright horrible (both in code and translations)
...
<friedel> aha: https://live.gnome.org/TranslationProject/DevGuidelines/Don%27t%20use%20anything%20besides%20ASCII%20or%20UTF-8%20in%20messages
<friedel> with "recent" in that page, keep in mind how old it is
<andre> that's from 2008, so might be outdated (or still correct).
<friedel> last change in 2008
<friedel> but that sounds like a blessing of non-ascii characters to me

Given this and that using these chars is really the only way to do this readably, and that these chars are so common that they will certainly be in every font, I think it is fine to proceed until we hear otherwise. Updating patch.
Comment 5 William Jon McCann 2012-08-14 14:47:37 UTC
Created attachment 221151 [details] [review]
Use double quotes instead of ascii quotes
Comment 6 Cosimo Cecchi 2012-08-14 15:34:12 UTC
Review of attachment 221151 [details] [review]:

This looks good to me now.
I think it'd be worthwhile to use double quotes consistently in GNOME, maybe we should start a GNOME Goal for 3.8 about this.
Comment 7 William Jon McCann 2012-08-14 15:46:38 UTC
Attachment 221151 [details] pushed as 6b3dd82 - Use double quotes instead of ascii quotes