After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681803 - alignment is poor in Image properties tab
alignment is poor in Image properties tab
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-13 23:52 UTC by William Jon McCann
Modified: 2012-08-14 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (48.71 KB, image/png)
2012-08-13 23:52 UTC, William Jon McCann 		  Details
Improve the Image properties page (7.27 KB, patch)
2012-08-14 00:41 UTC, William Jon McCann 		reviewed Details | Review
Improve the Image properties page (7.36 KB, patch)
2012-08-14 02:50 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2012-08-13 23:52:31 UTC 
Created attachment 221072 [details]
screenshot

The alignment is poor in the Image properties tab. It makes is really hard to read.
Comment 1 William Jon McCann 2012-08-14 00:41:26 UTC 
Created attachment 221086 [details] [review]
Improve the Image properties page
Comment 2 Cosimo Cecchi 2012-08-14 01:57:10 UTC 
Review of attachment 221086 [details] [review]:

I tried this and it looks great, thanks. I have a comment on the code below

::: src/nautilus-image-properties-page.c
@@ +351,2 @@
+	label = gtk_grid_get_child_at (GTK_GRID (page->details->grid), 0, 0);
+	gtk_container_remove (GTK_CONTAINER (page->details->grid), label);

Don't you have to do rows-- here?
I think you could remove the rows member from the private struct entirely, and use gtk_container_add() (which appends to the grid by default) and gtk_grid_insert_next_to() to pack the label and the value together.
Comment 3 William Jon McCann 2012-08-14 02:50:02 UTC 
Created attachment 221090 [details] [review]
Improve the Image properties page
Comment 4 Cosimo Cecchi 2012-08-14 09:16:57 UTC 
Review of attachment 221090 [details] [review]:

Looks good!
Comment 5 Cosimo Cecchi 2012-08-14 13:56:03 UTC 
This has been pushed now.