GNOME Bugzilla – Bug 681657
Integrate adblock extension
Last modified: 2012-10-07 16:12:21 UTC
It's important enough that we should really just ship it together with the browser. The only question, I think, is whether we should enable it by default or not.
Do you want to use this bug as a blocker bug for adblock bugs? Bug 617944 is a must-fix for example.
(In reply to comment #1)
> Do you want to use this bug as a blocker bug for adblock bugs? Bug 617944 is a
> must-fix for example.
Sure, we can do that.
Created attachment 225521 [details] [review]
Import adblock extension into the source tree
This commit imports the adblock extension from 'epiphany-extensions'
with as few modifications as possible. Further modifications and
simplifications are possible, but for now we just load it
We have it in the src/ directory because it depends on some high-level
objects in Epiphany (EphyExtension, EphyWindow), but in the future
we'll probably move it to embed/, transforming it from an extension
into just the specific implementation of our EphyAdblockManager
Created attachment 225522 [details] [review]
Add adblock GSetting, use it
org.gnome.epiphany.web.enable-adblock, controls whether adblock is
Created attachment 225523 [details] [review]
uri-tester: do not store the adblock data in the 'extensions' dir
We are on our way to stop being an extension.
Created attachment 225524 [details] [review]
prefs-dialog: add a checkbox to enable/disable the adblock functionality
OK, this is the basic stuff. Extension is integrated, some minor tweaks to make it work, and a GSetting + UI to control it. Seems to work fine.
Created attachment 225616 [details] [review]
ephy-adblock-manager: use new coding style
Created attachment 225617 [details] [review]
Remove UI code from adblock, un-extensionify it
We are not using this code for now, easy enough to re-add somehow if
we want to provide a UI to edit the adblock rules. With that gone,
it's now trivial to drop the extension code too, so now the adblocker
is just a GObject implementing the Adblock interface.
Created attachment 225618 [details] [review]
Move adblock extension to embed/
No reason for it to be in src/ now.
Created attachment 225619 [details] [review]
adblock: we don't use the edit rules stuff anymore, remove it
Created attachment 225620 [details] [review]
adblock: get rid of AdBlock interface
No need for this now, just make EphyAdBlock a concrete class
implementing the adblock functionality.
Well it seems there's not that many "blocker" bugs for this, so let's just fix #617944 and close this.