GNOME Bugzilla – Bug 681643
Port to new documentation infrastructure
Last modified: 2012-09-25 12:18:20 UTC
Created attachment 220921 [details] [review] Use-new-documentation-infrastructure Use yelp-tools instead of gnome-doc-utils. https://live.gnome.org/GnomeGoals/NewDocumentationInfrastructure
Review of attachment 220921 [details] [review]: I think the “ghelp” URIs in src/totem-object.c, help/C/totem.xml, help/C/legal.xml and their translations all need converting to “help” URIs. ::: help/Makefile.am @@ +5,2 @@ +HELP_FILES = \ + index.docbook Shouldn’t this patch also rename C/totem.xml to C/index.docbook?
Created attachment 222031 [details] [review] Use-new-documentation-infrastructure.v2 Yeah, here a new patch. Thanks for the review
friendly ping :)
Review of attachment 222031 [details] [review]: Looks good — please commit to master! (Sorry for not re-reviewing it sooner; Bugzilla didn’t e-mail me about the updated patch. :-( )
Comment on attachment 222031 [details] [review] Use-new-documentation-infrastructure.v2 commit 59a6bd6064fe7dd047f7b61642aba73e0ba72acf
Thanks for the review! :)
It looks like this was applied to master but no the gnome-3-6 branch. I presume it's too late for 3.6 as this would upset translations, right?
(In reply to comment #7) > It looks like this was applied to master but no the gnome-3-6 branch. I presume > it's too late for 3.6 as this would upset translations, right? Yes, it was accidentally not committed to the 3.6 branch, and it’s too late to fix that now. http://git.gnome.org/browse/totem/commit/?h=gnome-3-6&id=0d4a17ff31b4dcb9c902136ab80dd177a295dba8