GNOME Bugzilla – Bug 681624
basetransform: should try to reconfigure on not-negotiated
Last modified: 2018-11-03 12:15:46 UTC
+++ This bug was initially created as a clone of Bug #681198 +++ basetransform (e.g. videoconvert, videoscale) should try to reconfigure itself on not-negotiated if a reconfiguration is pending. Possibly even retry with the same buffer... (keeping a buffer ref doesn't force unnecessary memory copies downstream any more now, does it?)
Same for basesrc, baseparse and the audio/video encoder/decoder base classes
should be ok for basesrc: commit 5c0e02c79c88f8dddcf9b93bd9f30d75c24ac82e Author: Thiago Santos <thiago.sousa.santos@collabora.com> Date: Sat Aug 4 11:48:13 2012 -0300 basesrc: retry on not-negotiate if a reconfigure is pending Before erroring out on not-negotiated returns, check if the pad has the reconfigure flag set and retry. https://bugzilla.gnome.org/show_bug.cgi?id=681198 for basetransform this is not so easy, it might have consumed or modified the original buffer. > Possibly even retry with the same buffer... (keeping a buffer ref doesn't force > unnecessary memory copies downstream any more now, does it?) It does.
> > Possibly even retry with the same buffer... (keeping a buffer ref doesn't force > > unnecessary memory copies downstream any more now, does it?) > > It does. I was too fast, no it doesn't need to copy the memory anymore but when doing in-place it will have to do a copy in basetransform.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/27.