Created attachment 220891 [details] [review]
windowManager: Update dim effect

The combination of desaturating and lowering the brightness does
not work too well in all cases, in particular for applications
using the dark theme variant. Dropping the desaturation effect and
making the brightness adjustment more profound gives a better
result.

Created attachment 220892 [details] [review]
windowManager: Remove WindowDimmer class

Given that we now use a single clutter effect for dimming, we can
now just as well use the effect directly rather than the WindowDimmer
wrapper class.

Created attachment 220893 [details] [review]
Revert "windowManager: Update animation of attached modals"

This reverts commit 6ab25cd7912a623151d0d6aa5876cd6de1987ea9.

Created attachment 220894 [details] [review]
windowManager: Update animation of attached modals (again)

The fade animation we started using after centering attached
modal dialogs didn't work too well. So after going back to the
scale animation, adjust it to scale from the center rather
than the top, which works quite well.

Ping? Would be nice to get this in before the freeze ...

Review of attachment 220891 [details] [review]:

Sure.

Review of attachment 220892 [details] [review]:

::: js/ui/windowManager.js
@@ +261,3 @@
+                           transition: 'linear',
+                           onUpdate: function() {
+                               this.set_brightness(this._dimFactor * DIM_BRIGHTNESS);

Can't you tween the brightness directly? It has a "brightness" property.

Review of attachment 220893 [details] [review]:

Sure, I guess.

Review of attachment 220894 [details] [review]:

Meep.

(In reply to comment #7)
                          this.set_brightness(this._dimFactor *
> DIM_BRIGHTNESS);
> 
> Can't you tween the brightness directly? It has a "brightness" property.

It's a ClutterColor ...

(With the Clutter tweening framework, you can tween ClutterColors)

Attachment 220891 [details] pushed as ca7c4ed - windowManager: Update dim effect
Attachment 220893 [details] pushed as aaf61cb - Revert "windowManager: Update animation of attached modals"
Attachment 220894 [details] pushed as ff25a5e - windowManager: Update animation of attached modals (again)

Is work still needed there or can we close this one as FIXED?

I don't think so, no.