After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681537 - cancel is never reset .... cannot login after pressing escape once on the unlock screen
cancel is never reset .... cannot login after pressing escape once on the unl...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.5.x
Other Linux
: Normal major
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-09 17:15 UTC by Alban Browaeys
Modified: 2012-09-02 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdm: reset cancellable if cancelled (772 bytes, patch)
2012-08-09 17:15 UTC, Alban Browaeys 		committed Details | Review

Description Alban Browaeys 2012-08-09 17:15:19 UTC 
Created attachment 220810 [details] [review]
gdm: reset cancellable if cancelled

Otherwise the second attempt tot login after pressing "escape" key
on the login "freeze" and raise an exception about IOError operation
cancelled.
Comment 1 Ray Strode [halfline] 2012-08-10 19:56:44 UTC 
Review of attachment 220810 [details] [review]:

::: js/gdm/util.js
@@ +104,3 @@
         if (this._userVerifier)
             this._userVerifier.call_cancel_sync(null);
+        this._cancellable.reset();

looks okay, though might be "safer" to do

this._cancellable = new Gio.Cancellable();

instead (in the event some code somewhere does g_cancellable_is_cancelled (the_just_cancelled_and_reset_cancellable) as part of asynchronous cancellation)
Comment 2 Giovanni Campagna 2012-08-26 12:36:39 UTC 
Pushing to avoid forgetting again.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-02 19:16:17 UTC 
Was this fixed? Pushing escape while the the shield is being lifted makes the dialog appear and gives an "Operation was cancelled" error for me.
Comment 4 Giovanni Campagna 2012-09-02 20:39:48 UTC 
Uh, possible. And likely to be fixed by bug 682544. You could, you know, review it...