After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681508 - Windowing system checks need to be done runtime, not compile time
Windowing system checks need to be done runtime, not compile time
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-09 11:07 UTC by Tomas Frydrych
Modified: 2013-03-26 11:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playback: Fix X11 code running on non-X11 backends (1.17 KB, patch)
2013-03-26 10:43 UTC, Bastien Nocera 		committed Details | Review

Description Tomas Frydrych 2012-08-09 11:07:27 UTC 
In various places clutter-gst code checks for the windowing system using the '#if defined (CLUTTER_WINDOWING_X11)' construct; this was fine before the clutter backends were loadable, but now it makes it impossible to correctly build clutter-gst if clutter itself is built with multiple backends. E.g., if both x11 and egl backends are enabled in clutter, the resulting clutter-gst will only work against the x11 backend ...
Comment 1 Bastien Nocera 2013-03-26 10:43:21 UTC 
Created attachment 239853 [details] [review]
playback: Fix X11 code running on non-X11 backends

Check that we're running in X11 before calling
clutter_x11_get_default_display() and using its result.
Comment 2 Bastien Nocera 2013-03-26 10:44:55 UTC 
That should do it, there's a single X11-specific call in the whole thing (XInitThreads() just init's a few mutexes, it's harmless).
Comment 3 Emmanuele Bassi (:ebassi) 2013-03-26 10:52:24 UTC 
Review of attachment 239853 [details] [review]:

looks good to me.
Comment 4 Bastien Nocera 2013-03-26 11:09:32 UTC 
Attachment 239853 [details] pushed as b23c0c0 - playback: Fix X11 code running on non-X11 backends