After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681491 - v4l2: build fails with recent kernel: struct v4l2_buffer' has no member named 'input'
v4l2: build fails with recent kernel: struct v4l2_buffer' has no member named...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other Linux
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-09 03:22 UTC by Matthias Clasen
Modified: 2012-08-09 07:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Clasen 2012-08-09 03:22:20 UTC
I'm getting 

make[4]: Entering directory `/home/mclasen/Sources/gst-plugins-good/sys/v4l2'
  CC       libgstvideo4linux2_la-gstv4l2bufferpool.lo
gstv4l2bufferpool.c: In function 'gst_v4l2_buffer_new':
gstv4l2bufferpool.c:185:3: error: 'struct v4l2_buffer' has no member named 'input'

when trying to build gst-plugins-good in current rawhide.
Comment 1 Matthias Clasen 2012-08-09 03:23:56 UTC
Removing the offending line is enough to fix the build:

diff --git a/sys/v4l2/gstv4l2bufferpool.c b/sys/v4l2/gstv4l2bufferpool.c
index 2e3a563..5aaed5a 100644
--- a/sys/v4l2/gstv4l2bufferpool.c
+++ b/sys/v4l2/gstv4l2bufferpool.c
@@ -182,7 +182,6 @@ gst_v4l2_buffer_new (GstV4l2BufferPool * pool, guint index, 
     GST_LOG_OBJECT (pool->v4l2elem, "  MMAP offset:  %u",
         ret->vbuffer.m.offset);
   GST_LOG_OBJECT (pool->v4l2elem, "  length:    %u", ret->vbuffer.length);
-  GST_LOG_OBJECT (pool->v4l2elem, "  input:     %u", ret->vbuffer.input);
 
   ret->mmap_length = ret->vbuffer.length;
   data = (guint8 *) v4l2_mmap (0, ret->vbuffer.length,
Comment 2 Tim-Philipp Müller 2012-08-09 07:34:21 UTC
Looks like user space doesn't matter:

From 2b719d7baf490e24ce7d817c6337b7c87fda84c1 Mon Sep 17 00:00:00 2001
From: Sakari Ailus <sakari.ailus@iki.fi>
Date: Wed, 2 May 2012 09:40:03 -0300
Subject: [PATCH] [media] v4l: drop v4l2_buffer.input and V4L2_BUF_FLAG_INPUT

Remove input field in struct v4l2_buffer and flag V4L2_BUF_FLAG_INPUT which
tells the former is valid. The flag is used by no driver currently.

Also change the documentation accordingly.

Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Comment 3 Tim-Philipp Müller 2012-08-09 07:41:56 UTC
Thanks, fixed in 0.10 and master:

 commit bfb1ac952b4c3caaba0297bbe7dc73ea92f9b292
 Author: Matthias Clasen <mclasen@redhat.com>
 Date:   Thu Aug 9 08:35:23 2012 +0100

    v4l2: fix build with recent kernels, the v4l2_buffer input field was removed
    
    This was unused apparently and removed in the kernel in commit:
    
     From 2b719d7baf490e24ce7d817c6337b7c87fda84c1 Mon Sep 17 00:00:00 2001
     From: Sakari Ailus <sakari.ailus@iki.fi>
     Date: Wed, 2 May 2012 09:40:03 -0300
     Subject: [PATCH] [media] v4l: drop v4l2_buffer.input and V4L2_BUF_FLAG_INPUT
    
     Remove input field in struct v4l2_buffer and flag V4L2_BUF_FLAG_INPUT which
     tells the former is valid. The flag is used by no driver currently.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=681491