After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681489 - Fix the build with webkit 1.9.6
Fix the build with webkit 1.9.6
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-09 02:16 UTC by Matthias Clasen
Modified: 2018-05-22 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the build with webkit 1.9.6 (1.38 KB, patch)
2012-08-09 02:16 UTC, Matthias Clasen 		reviewed Details | Review

Description Matthias Clasen 2012-08-09 02:16:38 UTC 
The webkit_dom_html_element_[gs]et_class_name API got moved
to from WebKitDOMHTMLElement to WebKitDOMElement.
Comment 1 Matthias Clasen 2012-08-09 02:16:40 UTC 
Created attachment 220758 [details] [review]
Fix the build with webkit 1.9.6
Comment 2 Matthias Clasen 2012-08-09 02:21:34 UTC 
It would be great if we could get a 3.5.5.1 tarball with this fix for the GNOME 3.5.5 release.
Comment 3 Guillaume Desmottes 2012-08-09 06:48:49 UTC 
Review of attachment 220758 [details] [review]:

Is this API breakage really intended? I've been told it was a bug in this webkit-gtk release, see https://bugs.webkit.org/show_bug.cgi?id=93384

I'd rather wait for a fixed webkit-gtk released than bumping the webkit-gtk dep (which your branch didn't do btw), webkit being so annoying to build for all contributors.
Comment 4 Guillaume Desmottes 2012-08-09 07:56:42 UTC 
Xan: are you planning to do a new Webkit release fixing this API breakage?
Comment 5 Matthias Clasen 2012-08-09 16:00:19 UTC 
You can also do an ifdef like the evolution team did here:
 http://git.gnome.org/browse/evolution/commit/?id=b24af8b9cd942e50c43c61e7e688fda175ea858f

Anyway, I'll point to this bug in the release announcement for 3.5.5.
Comment 6 GNOME Infrastructure Team 2018-05-22 15:39:43 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/577.