After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681469 - port to gstreamer 1.0
port to gstreamer 1.0
Product: rhythmbox
Classification: Other
Component: general
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on: 680797
Blocks: 679412
Reported: 2012-08-08 18:15 UTC by Matthias Clasen
Modified: 2012-12-08 07:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Port the DAAP plugin to GStreamer 1.0 (7.77 KB, patch)
2012-11-26 12:07 UTC, Iain Lane
committed Details | Review
WIP visualization port (4.59 KB, patch)
2012-11-27 12:12 UTC, Iain Lane
needs-work Details | Review

Comment 1 Tim-Philipp Müller 2012-10-18 13:16:50 UTC
Edward has more fixes here:

(no idea why he didn't push those into the branch on
Comment 2 Javier Jardón (IRC: jjardon) 2012-11-07 06:45:33 UTC
Can we have an update on this?
With this ported I could remove GStreamer 0.10 from my disk ;)
Comment 3 Jonathan Matthew 2012-11-07 06:53:17 UTC
Current work on this is in the gstreamer-1.0 branch:

includes everything from Edward's branch and a couple more fixes.
Comment 4 Iain Lane 2012-11-26 10:20:00 UTC
The branch disables the daap and visualization extensions because libdmapsharing and clutter-gst weren't ported to GStreamer 1.0 at the time.

They are now.

I'm working on porting DAAP, and will post patches here against the gstreamer-1.0 branch soon.

Not sure yet if I'll work on visualization; guess it depends what needs doing there.

Cheers. :-)
Comment 5 Iain Lane 2012-11-26 12:07:36 UTC
Created attachment 229894 [details] [review]
Port the DAAP plugin to GStreamer 1.0

Depends on the (as-yet) unreleased port of libdmapsharing (BGO #680797).
Comment 6 Iain Lane 2012-11-26 18:22:40 UTC
I can't get visualizer to not segfault RB. Clearly hitting a hole in my brain somewhere. I'll post my WIP up here tomorrow.
Comment 7 Jonathan Matthew 2012-11-26 22:56:32 UTC
Comment on attachment 229894 [details] [review]
Port the DAAP plugin to GStreamer 1.0

pushed this as commit 023820c, thanks
Comment 8 Jonathan Matthew 2012-11-26 23:10:44 UTC
You might need the recent XInitThreads fix to get clutter stuff working. I've just applied this to the gstreamer-1.0 branch. git will probably kill me for doing this later.
Comment 9 Iain Lane 2012-11-27 12:12:39 UTC
Created attachment 229991 [details] [review]
WIP visualization port

OK, that commit makes RB stop segfaulting here.

There's still a problem that I can't figure out, probably due to lacking a sufficiently global view of what's going on in this plugin. If you switch to the visualisation, playback stalls with an underflow (and the visualisation of course never appears).

Here's what I have. I'm going to stop working on this now, at least for a while. Perhaps someone else with more familiarity with this code knows what's going on.
Comment 10 Jonathan Matthew 2012-12-02 23:04:34 UTC
Aside from visualization (obviously), everything appears to be working properly now. If I don't spot any major problems in the next few days, I'm going to push the current gstreamer-1.0 branch to master.
Comment 11 Jonathan Matthew 2012-12-08 07:38:55 UTC
I just pushed the gstreamer 1.0 port to master. Opening a new bug for the visualizer plugin.