GNOME Bugzilla – Bug 681452
Rygel should make the same error message in the same error code.
Last modified: 2012-08-12 18:15:31 UTC
I noticed that error message set together with the error code of Rygel("action.return_error" methods) have little variation. For example... * Same error code but error messages written by other words. librygel-core/rygel-connection-manager.vala:125: action.return_error (402, _("Invalid argument")); librygel-renderer/rygel-rendering-control.vala:123: action.return_error (402, _("Invalid Args")); * Same error code but error message means same or not? librygel-renderer/rygel-rendering-control.vala:160: action.return_error (701, _("Invalid Name")); librygel-renderer/rygel-av-transport.vala:497: action.return_error (701, _("Transition not available")); * Same error code but error message other mean? librygel-renderer/rygel-av-transport.vala:481: action.return_error (717, _("Play speed not supported")); librygel-server/rygel-content-directory.vala:217: action.return_error (717, _("No such file transfer")); I think it should make the same error message in the same error code. (This also means make the same i18n error message in the same error code.)
Ah, I'm afraid that's not possible for the 7xx codes as they change meaning depending on the context. Wasn't our idea, that comes from the UPnP forum. We can check the messages for those error codes that are identical though.