After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681448 - 1.13.6 does not build with libgphoto2 < 2.5.0
1.13.6 does not build with libgphoto2 < 2.5.0
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
1.13.x
Other Windows
: Normal major
: ---
Assigned To: gvfs-maint
gvfs-maint
: 683957 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-08-08 13:10 UTC by Dominique Leuenberger
Modified: 2012-09-13 14:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support gphoto 2.5, but do not require it. (1.21 KB, patch)
2012-08-08 13:13 UTC, Dominique Leuenberger 		none Details | Review

Description Dominique Leuenberger 2012-08-08 13:10:03 UTC 
1.13.6 introduces support for libgphoto 2.5.

Unfortunately, the way configure checks for it is not working, and results in ALWAYS flagging 2.5 support if libgphoto2 is found, due to the fact that
PKG_CHECK_MODULES(GPHOTO2, libgphoto2 >= 2.5.0,
 => reuses GPHOTO2, which had been 'confirmed' earlier and is now defined already.

so configure passes over it and 'agrees' to it.

Changing that line to
PKG_CHECK_MODULES(GPHOTO25, libgphoto2 >= 2.5.0,

resolves the issue (but then actually fails, as libgphoto 2.5 becomes 'mandatory')

I'll shortly attach a patch which corrects this.
Comment 1 Dominique Leuenberger 2012-08-08 13:13:45 UTC 
Created attachment 220669 [details] [review]
Support gphoto 2.5, but do not require it.
Comment 2 Dominique Leuenberger 2012-08-20 18:08:28 UTC 
Just as a reminder: This patch is still needed on gvfs 1.13.7 to support gphoto < 2.5 due to the way configure caches results.
Comment 3 Alexander Larsson 2012-08-20 18:17:31 UTC 
Pushed to master
Comment 4 Marcus Meissner 2012-09-13 14:26:04 UTC 
*** Bug 683957 has been marked as a duplicate of this bug. ***