Created attachment 220667 [details] [review]
display a special error message if UOA SSO account get an auth error

I don't like the way this is done. IMO telepathy should give a more precise error like TP_ERROR_NOT_AUTHORIZED, like that it would just be a matter of adding it to empathy-utils.c::create_errors_to_message_hash(). Looking at wocky logs it seems it knows the error is not-authorized but it raise a generic TP_ERROR_AUTHENTIFICATION_FAILED.

Note that there is a more serious issue: if I change my facebook pwd, or remove the Ubuntu app from my account, then gabble will fail to connect but in gnome-control-center it won't let me re-auth because SSO does not know the access token has been invalidated.

According the Mardy, if XMPP auth fails, we should call signon_auth_session_process() with "UiPolicy": RequestPasswordPolicy in the parameters.

(In reply to comment #2)
> Note that there is a more serious issue: if I change my facebook pwd, or remove
> the Ubuntu app from my account, then gabble will fail to connect but in
> gnome-control-center it won't let me re-auth because SSO does not know the
> access token has been invalidated.
> 
> According the Mardy, if XMPP auth fails, we should call
> signon_auth_session_process() with "UiPolicy": RequestPasswordPolicy in the
> parameters.

Fixed this.

Tbh I don't see what's wrong with the generic authentification failed message with the 3 buttons reconnect, edit and ignore.

Created attachment 223758 [details] [review]
EmpathyRosterWindow: Add UOA specific error infobar

Review of attachment 223758 [details] [review]:

Contains new string, commit after freeze.

Attachment 223758 [details] pushed as c98ab50 - EmpathyRosterWindow: Add UOA specific error infobar