GNOME Bugzilla – Bug 681400
Fails to build, API changed in webkit
Last modified: 2013-09-13 01:06:39 UTC
I'm trying to build the git/master of evolution. The build dies with: make[5]: Entering directory `/home/ronis/Project/notar/GNOME/garnome/svn/evolution/work/main.d/evolution-git/widgets/misc' CC libemiscwidgets_la-e-web-view.lo e-web-view.c: In function 'web_view_update_document_highlights': e-web-view.c:472:3: error: implicit declaration of function 'webkit_dom_html_element_set_class_name' [-Werror=implicit-function-declaration] e-web-view.c:472:3: warning: nested extern declaration of 'webkit_dom_html_element_set_class_name' [-Wnested-externs] cc1: some warnings being treated as errors make[5]: *** [libemiscwidgets_la-e-web-view.lo] Error 1 I'd just upgraded to webkit-1.9.6 (from 1.9.5).
Dan, would you mind to have a look on this, please? You can add conditional compilation for webkit version 9I hope they provide such macro, or you can use tests from configure.ac, like I did for functions in evolution-mapi: http://git.gnome.org/browse/evolution-mapi/commit/configure.ac?id=c20420c6536bde58f772a212217c01add71fc3f1
Created attachment 220695 [details] [review] Fix In WebKitGtk+ 1.9.6, webkit_dom_html_element_{get,set}_class_name() functions were accidentally renamed to webkit_dom_element_{get,set}_class_name(). This will be fixed in WebKitGtk+ 1.9.7, which will provide the original function again as well as the "new" one (for compatibility reasons). For details, see http://lists.webkit.org/pipermail/webkit-gtk/2012-August/001200.html
Comment on attachment 220695 [details] [review] Fix Committed to git master as b24af8b9 http://git.gnome.org/browse/evolution/commit/?id=b24af8b9cd942e50c43c61e7e688fda175ea858f This can be reverted once we require WebKitGtk+ 1.10.0+