GNOME Bugzilla – Bug 681385
build: Add --disable-man
Last modified: 2018-01-05 20:26:49 UTC
Created attachment 220569 [details] [review] build: Add --disable-man 1) For embedded systems, it makes no sense to include documentation of this kind on each image. So we might as well not even build it. 2) For people bootstrapping systems from source code, documentation is the source of many cyclical build loops. Allowing it to be disabled helps cut these loops. 3) The Docbook stylesheets are distributed as Zip files, and I refuse to put that bullshit into my build system.
I think 1) and 3) are rather weak, but 2) is convincing. glib has a bunch of configury that you can copy
Review of attachment 220569 [details] [review]: ::: configure.ac @@ +26,3 @@ + enable_man=yes) + +if test "$enable_man" != no; then isn't putting things like AC_PATH_PROG inside of open-coded 'if's the sort of thing that got us into trouble with so many other bugs? @@ +27,3 @@ + +if test "$enable_man" != no; then + AC_PATH_PROG([XSLTPROC], [xsltproc]) don't we also need xsltproc for gtk-doc, or will that take care of it itself?
Created attachment 225686 [details] [review] build: Add --disable-man Now using AS_IF
(In reply to comment #2) > @@ +27,3 @@ > + > +if test "$enable_man" != no; then > + AC_PATH_PROG([XSLTPROC], [xsltproc]) > > don't we also need xsltproc for gtk-doc, or will that take care of it itself? gtk-doc should depend on it; in other words, if gtk-doc is enabled, it's a system construction error if it doesn't exist.