GNOME Bugzilla – Bug 681357
New world clock dialog - layout issues
Last modified: 2012-08-17 13:40:19 UTC
Created attachment 220517 [details] screenshot and mockup There are a bunch of layout issues with the current new world clock dialog. There's a couple of strings that could be tweaked, too. Issues: * Title text is too big, should probably read "Add a World Clock" (does this need to be set as the window title?) * Too much vertical padding between title and content below * "Search for a city of time zone..." looks slightly too far to the left to me, and it doesn't need the "..." * Too much vertical padding between the "Search for a" text and the search box Cancel and Save button aren't right aligned with the search box * "Save" should be "Add" See the attachment for guidance.
Created attachment 221296 [details] [review] Layout fixes for alarm dialog I think i take most of your concern into consideration, the only thing left is to align dialog button with the search entry. I still need to figure out how to do it.
Created attachment 221297 [details] [review] Layout fixes for the alarm dialog I forget to remove the dots...
Created attachment 221333 [details] [review] Layout fixes for the alarm dialog Now entry and button alignment is fine. Please let me know what you think. I left a 5px border between control and window, I don't know what the new standard is (gnome 3 HIG are not complete on this point).
I seem to have given this bug the wrong title - updating. Maël: can you file a new bug and attach your patches there?
Created attachment 221414 [details] [review] fixes for add world clock dialog & stopwatch Fixes add-world clock dialog box, and removes "Lap" button from stopwatch
I give the wrong title to my patches too, they fixes the new world clock dialog :p Emily: Seems to be the wrong patch.
Created attachment 221416 [details] [review] Change add-world clock & remove lap button Right, trying this again :) Change add-world clock Remove Lap button
(In reply to comment #7) > Created an attachment (id=221416) [details] [review] > Change add-world clock & remove lap button > > Right, trying this again :) > > Change add-world clock > > Remove Lap button Shouldn't this be one patch for each issue?
Created attachment 221421 [details] [review] Fix NewWorldClock dialog alignment
(In reply to comment #8) > Shouldn't this be one patch for each issue? Yes, we discussed this on irc, but splitting was a bit of a pain. So it was committed as is. There is still some work to do on the Stopwatch button and Emily is working on it. I also committed Mael's last patch which fixes the alignment. Thanks! I am closing this bug since it is fixed and since the Stopwatch button is another topic (hopefully it will be solved shortly so no need for a bugreport)
The padding is still out. There's too much vertical spacing between the heading and the text below, too much between "Search for a city" and the search box, and not enough padding between the controls and the window edge.
Created attachment 221582 [details] Screenshot Here's a screenshot of a glade file I created with the correct layout. Note that I've created this as a modal dialog which uses the window title for the "Add a New World Clock" heading. This is because window titles will be reintroduced into modal dialogs for GNOME 3.6.
Created attachment 221583 [details] Glade file Here's the Glade file, in case you're interested.