After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681356 - Support [HasEmitter] for vala sources
Support [HasEmitter] for vala sources
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Code Generator: GSignal
0.17.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on: 641828
Blocks:
 
 
Reported: 2012-08-07 08:46 UTC by Evan Nemerson
Modified: 2016-10-12 20:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support HasEmitter for vala sources (4.39 KB, patch)
2016-10-11 19:37 UTC, Simon Werbeck 		committed Details | Review

Description Evan Nemerson 2012-08-07 08:46:51 UTC 
Adding [HasEmitter] to a signal has no effect on either the generated C or the GIR.  Test case:


[CCode (gir_namespace = "Foo", gir_version = "1.0")]
namespace Foo {
  public class Bar : GLib.Object {
    [HasEmitter]
    public signal void baz ();
  }
}
Comment 1 Simon Werbeck 2016-10-11 19:37:28 UTC 
Created attachment 337463 [details] [review]
Support HasEmitter for vala sources

Based on the proposed patch for bug 641828.
Comment 2 Rico Tzschichholz 2016-10-12 11:17:37 UTC 
Review of attachment 337463 [details] [review]:

Thank! Although, this generates invalid ccode and "make check" fails.
Comment 3 Rico Tzschichholz 2016-10-12 12:02:29 UTC 
Review of attachment 337463 [details] [review]:

Sorry, I misread the required bug reference.
Comment 4 Rico Tzschichholz 2016-10-12 20:27:52 UTC 
commit e1ed6ce78bfef1f7d71fd26c4523fc6c8c431bc5
Author: Simon Werbeck <simon.werbeck@gmail.com>
Date:   Wed Oct 5 19:01:58 2016 +0200

    Support [HasEmitter] for vala sources