GNOME Bugzilla – Bug 681328
portability: get WIFEXITED and WEXITSTATUS from sys/wait.h
Last modified: 2012-12-16 14:19:02 UTC
Created attachment 220484 [details] [review] get WIFEXITED and WEXITSTATUS from sys/wait.h Hi. Linux has a definition for WIFEXITED and WEXITSTATUS in both stdlib.h and sys/wait.h which is not the case on at least FreeBSD and OpenBSD. The norm is to get them from sys/wait.h which should work on all Unices. Otherwise on !linux, we end up with: screen.o(.text+0x2a9f): In function `meta_screen_new': : warning: sprintf() is often misused, please use snprintf() delete.o(.text+0x462): In function `dialog_exited': : undefined reference to `WIFEXITED' delete.o(.text+0x485): In function `dialog_exited': : undefined reference to `WEXITSTATUS' Would that be alright to push?
Anyone?
If it doesn't break Linux, then please commit.
Btw: Build fixes are generally ok to commit. Just make very sure that you know what you're doing. Meaning: only small and really obvious fixes plus fix has to be tested.
Thank you Olav. It's in as f94e552... Build was successfully tested on Linux.