After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681312 - Add TLS SNI support on the server-side
Add TLS SNI support on the server-side
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: network
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-08-06 15:53 UTC by Marcin Lewandowski
Modified: 2018-05-29 06:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add TLS SNI support (GIO) (4.83 KB, patch)
2012-08-06 15:53 UTC, Marcin Lewandowski 		needs-work Details | Review
Add TLS SNI support (glib-networking) (11.62 KB, patch)
2012-08-06 15:54 UTC, Marcin Lewandowski 		needs-work Details | Review

Description Marcin Lewandowski 2012-08-06 15:53:43 UTC 
Created attachment 220462 [details] [review]
Add TLS SNI support (GIO)

Hi,

I've created small patch that enables TLS SNI support while using GnuTLS backend.

It adds new signal GTlsServerConnection::received-server-identity which allows to set proper certificate based on received server name.
Comment 1 Marcin Lewandowski 2012-08-06 15:54:05 UTC 
Created attachment 220464 [details] [review]
Add TLS SNI support (glib-networking)
Comment 2 Quentin "Sardem FF7" Glidic 2016-04-11 08:39:24 UTC 
Could we finally have that feature?
Comment 3 Michael Catanzaro 2017-10-17 15:04:45 UTC 
Review of attachment 220462 [details] [review]:

Sorry for the half-decade delay.

This seems useful, but the patch is malformed... if you want to push this forward, we need a git-formatted patch based on the upstream git directory, not a Debian package. If you can't apply it using 'git am' then it's not ready for review.
Comment 4 Michael Catanzaro 2017-10-17 15:07:07 UTC 
Review of attachment 220464 [details] [review]:

Ditto.
Comment 5 Michael Catanzaro 2017-10-17 15:07:16 UTC 
Review of attachment 220462 [details] [review]:

Sorry for the half-decade delay.

This seems useful, but the patch is malformed... if you want to push this forward, we need a git-formatted patch based on the upstream git directory, not a Debian package. If you can't apply it using 'git am' then it's not ready for review.
Comment 6 Dan Winship 2017-10-17 20:17:15 UTC 
The wip/danw/tls-new-apis branch of glib and wip/danw/sni branch of glib-networking contain slightly-updated versions of the patches here
Comment 7 Marcin Lewandowski 2017-10-18 17:16:29 UTC 
Guys, at the moment I totally don't have capacity to work on this, hopefully what Dan has made will be OK.
Comment 8 GNOME Infrastructure Team 2018-05-24 14:25:42 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/583.
Comment 9 Michael Catanzaro 2018-05-25 16:35:12 UTC 
Reopening. This bug was migrated to https://gitlab.gnome.org/GNOME/glib, but it should have been migrated to https://gitlab.gnome.org/GNOME/glib-networking.
Comment 10 Christoph Reiter (lazka) 2018-05-29 06:43:14 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib-networking/issues/24.