After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681260 - Add source-setup signal to GstDiscoverer
Add source-setup signal to GstDiscoverer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-06 00:19 UTC by LRN
Modified: 2012-08-06 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
source-setup signal for GstDiscoverer (4.62 KB, patch)
2012-08-06 00:19 UTC, LRN 		needs-work Details | Review
source-setup signal for GstDiscoverer (fixed) (4.60 KB, patch)
2012-08-06 11:31 UTC, LRN 		committed Details | Review

Description LRN 2012-08-06 00:19:01 UTC 
That would allow one to use GstDiscoverer with wide variety of URIs (such as appsrc://) that require special setup for their corresponding sources.
Comment 1 LRN 2012-08-06 00:19:45 UTC 
Created attachment 220404 [details] [review]
source-setup signal for GstDiscoverer
Comment 2 Sebastian Dröge (slomo) 2012-08-06 08:42:29 UTC 
Review of attachment 220404 [details] [review]:

Looks good except:

::: gst-libs/gst/pbutils/gstdiscoverer.c
@@ +262,3 @@
+   * thread.
+   *
+   * Since: X.XX.XX

Just remove the Since marker here

@@ +544,3 @@
+  GstElement *src;
+  /* get a handle to the source */
+  g_object_get (uridecodebin, pspec->name, &src, NULL);

You have to unref src after usage, otherwise you leak it
Comment 3 LRN 2012-08-06 11:31:34 UTC 
Created attachment 220428 [details] [review]
source-setup signal for GstDiscoverer (fixed)
Comment 4 Sebastian Dröge (slomo) 2012-08-06 12:43:22 UTC 
commit 8f33ad80d0ae70c700a667b7ab08cc4ccd157232
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Mon Aug 6 15:23:51 2012 +0400

    discoverer: Add source-setup signal for GstDiscoverer
    
    https://bugzilla.gnome.org/show_bug.cgi?id=681260