After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681253 - Don't use GDK_THREADS_ENTER/LEAVE
Don't use GDK_THREADS_ENTER/LEAVE
Status: RESOLVED FIXED
Product: ghex
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GHex maintainers
GHex maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-05 19:44 UTC by Matthias Clasen
Modified: 2012-08-06 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't use GDK_THREADS_ENTER/LEAVE (1.02 KB, patch)
2012-08-05 19:44 UTC, Matthias Clasen
accepted-commit_now Details | Review
Don't use GDK_THREADS_ENTER/LEAVE (1.02 KB, patch)
2012-08-06 16:56 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2012-08-05 19:44:17 UTC
We're not calling gdk_threads_init, so ENTER/LEAVE are no-ops
anyway.
Comment 1 Matthias Clasen 2012-08-05 19:44:19 UTC
Created attachment 220395 [details] [review]
Don't use GDK_THREADS_ENTER/LEAVE
Comment 2 Kalev Lember 2012-08-06 08:51:38 UTC
Review of attachment 220395 [details] [review]:

Thanks, looks good to me.

ghex-window.c is only used in the GHex app and is not part of the GtkHex shared library, so we can be sure this won't get called from client apps that could possibly call gdk_threads_init().
Comment 3 Matthias Clasen 2012-08-06 16:56:46 UTC
The following fix has been pushed:
1389da5 Don't use GDK_THREADS_ENTER/LEAVE
Comment 4 Matthias Clasen 2012-08-06 16:56:48 UTC
Created attachment 220471 [details] [review]
Don't use GDK_THREADS_ENTER/LEAVE

We're not calling gdk_threads_init, so ENTER/LEAVE are no-ops
anyway.