After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681231 - Autogenerated files in Git Repository ("docs/C/texinfo.tex", "install-sh")
Autogenerated files in Git Repository ("docs/C/texinfo.tex", "install-sh")
Status: RESOLVED FIXED
Product: gcompris
Classification: Other
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Bruno Coudoin
Rami Aubourg-Kaires
Depends on:
Blocks:
 
 
Reported: 2012-08-05 12:41 UTC by Peter Albrecht
Modified: 2012-08-30 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch showing the differences listed by "git diff". (105.59 KB, patch)
2012-08-05 12:41 UTC, Peter Albrecht
none Details | Review

Description Peter Albrecht 2012-08-05 12:41:07 UTC
Created attachment 220361 [details] [review]
Patch showing the differences listed by "git diff".

The git repository contains two files, which are generated during "sh autogen.sh":

  - ./install-sh
  - ./docs/C/texinfo.tex

The problem is: The files generated on my system are different from those in the git repo. So after running "sh autogen.sh", "git status" always lists those two files as modified.

If I delete those two files on a clean git checkout, "sh autogen.sh", "make" and "make install" run without any problems.

I dont know very much about autogen/make internals. But from my simple point of view, I would suggest to remove those two files from the git repository.
Comment 1 Bruno Coudoin 2012-08-28 20:29:17 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Peter Albrecht 2012-08-29 19:22:30 UTC
Thanks for taking care of this bug! :)

https://github.com/bdoin/GCompris/commit/16aded2ce05c2e448fc0e71ae78f2a938d3c9577

I would say, the two files should also be added to the corresponding ".gitignore" file. At current state, they are listed as untracked files.
Comment 3 Bruno Coudoin 2012-08-29 21:07:30 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Peter Albrecht 2012-08-30 19:39:49 UTC
Thanks alot! :)